[PM-15963]Fix duplicate key in en/messages.json #12375
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be done, because Firefox compares the keys case-insensitive when a release is uploaded to the store.
…/pm-15963/fix-duplicate-key-in-messages.json
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12375 +/- ##
=======================================
Coverage 33.36% 33.36%
=======================================
Files 2908 2908
Lines 90978 90978
Branches 17325 17325
=======================================
Hits 30356 30356
Misses 58219 58219
Partials 2403 2403 ☔ View full report in Codecov by Sentry. |
ike-kottlowski
approved these changes
Dec 12, 2024
djsmith85
deleted the
auth/pm-15963/fix-duplicate-key-in-messages.json
branch
djsmith85
added a commit
that referenced
this pull request
Dec 12, 2024
This needs to be done, because Firefox compares the keys case-insensitive when a release is uploaded to the store. Co-authored-by: Daniel James Smith <[email protected]> (cherry picked from commit 46e2e02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15963
📔 Objective
Fix duplicate key in en/messages.json
This needs to be done, because Firefox compares the keys case-insensitive when a release is uploaded to the store.
After this is merged, I'll run a Crowdin Sync and then this and the Crowdin Sync browser PR will need to be 🍒 ⛏️ 'ed to
rc⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes